Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add class-names for push-analytics #2966

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

HendrikThePendric
Copy link
Contributor

@HendrikThePendric HendrikThePendric commented Jan 24, 2024

Implements: No issue number available

Requires dhis2/analytics#1620


Key features

  1. Adds class-names to elements that push-analytics need to interact with

TODO

@HendrikThePendric HendrikThePendric marked this pull request as draft January 24, 2024 12:40
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jan 24, 2024

@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2024 12:44 Inactive
Copy link

cypress bot commented Jan 24, 2024

3 flaky tests on run #2634 ↗︎

0 393 1 0 Flakiness 3

Details:

Merge a7bf7f3 into 065c4b1...
Project: Data Visualizer App Commit: 7b887288d6 ℹ️
Status: Passed Duration: 06:08 💡
Started: Jan 29, 2024 9:53 AM Ended: Jan 29, 2024 9:59 AM
Flakiness  open.cy.js • 1 flaky test • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
opening a saved AO > navigates to the start page Test Replay Screenshots Video
Flakiness  dimensions/data.cy.js • 2 flaky tests • e2e-chrome-parallel-2.40

View Output Video

Test Artifacts
Data dimension > displays Event data items correctly Test Replay Screenshots Video
Data dimension > displays Program indicators correctly Test Replay Screenshots Video

Review all test suite changes for PR #2966 ↗︎

@HendrikThePendric
Copy link
Contributor Author

Note that class name push-analytics-download-menu-item is used in both the chart download menu and the table download menu. This is intentional because it allows the download to be triggered in a single way.

@HendrikThePendric HendrikThePendric marked this pull request as ready for review January 24, 2024 15:59
@HendrikThePendric HendrikThePendric marked this pull request as draft January 24, 2024 15:59
@dhis2-bot dhis2-bot temporarily deployed to netlify January 24, 2024 16:01 Inactive
@HendrikThePendric HendrikThePendric marked this pull request as ready for review January 26, 2024 09:48
@dhis2-bot dhis2-bot temporarily deployed to netlify January 26, 2024 09:49 Inactive
@HendrikThePendric HendrikThePendric merged commit 5872a5a into dev Jan 29, 2024
33 of 34 checks passed
@HendrikThePendric HendrikThePendric deleted the feat/add-class-names-for-push-analytics branch January 29, 2024 10:07
dhis2-bot added a commit that referenced this pull request Mar 19, 2024
# [100.5.0](v100.4.0...v100.5.0) (2024-03-19)

### Bug Fixes

* **translations:** sync translations from transifex (dev) ([dbb683f](dbb683f))
* fetch displayTitle and displaySubtitle for translations DHIS2-16216 ([#2929](#2929)) ([d6f327a](d6f327a))
* **push-analytics:** add push analytics instructions ([#2985](#2985)) ([77c5bcd](77c5bcd))
* **translations:** sync translations from transifex (dev) ([476e8a8](476e8a8))
* **translations:** sync translations from transifex (dev) ([459c53c](459c53c))
* **translations:** sync translations from transifex (dev) ([2966187](2966187))
* add custom errors for analytics requests ([#2874](#2874)) ([cc3fcd1](cc3fcd1))

### Features

* add class-names for push-analytics ([#2966](#2966)) ([5872a5a](5872a5a))
* support Outlier table visualization type (DHIS2-13858) ([#2942](#2942)) ([e9c31a7](e9c31a7))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants